tsconfig: Use "solution" tsconfig for more correct type checking #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbates35
force-pushed
the
tsconfig-updates
branch
2 times, most recently
from
ed6e058
to
3353f7e
Compare
As we're building a web app it makes sense to use jsdom environment instead of the default node environment, so that we can do things such as demonstrated in the test that was added (taken from https://vitest.dev/config/#environment), which currently isn't possible.
Add a test proving that jsdom types are working as expected, the node types will be used in a later commit.
philbates35
force-pushed
the
tsconfig-updates
branch
from
3353f7e
to
2a103ee
Compare
The change in 2aa6462 is resulting in a vite.config.js and vite.config.d.ts being generated which we don't want. To fix this, lets do the "solution" tsconfig approach as used by the create-vue project. This results in things like the following, all of which aren't enforced currently: * tsc allows "process.cwd()" in vite.config.ts and sum.test.ts but not in any src files such as app.ts * tsc allows document.createElement() in src files such as app.ts and in sum.test.ts (because jsdom exists there) but not in vite.config.ts which is just pure node environment. * Can't import test files into src files * Allows using new features such as "".replaceAll() in vite.config.ts which should be allowed because we're using node 20. See: * vitejs/vite#15913 (comment) * https://github.com/vuejs/create-vue/blob/12bf2889b9ca981bcfed894a7c24fa9db5e7bad5/template/tsconfig/base/tsconfig.app.json * https://github.com/vuejs/create-vue/blob/12bf2889b9ca981bcfed894a7c24fa9db5e7bad5/template/tsconfig/base/tsconfig.node.json * https://github.com/vuejs/create-vue/blob/12bf2889b9ca981bcfed894a7c24fa9db5e7bad5/template/tsconfig/vitest/tsconfig.vitest.json
philbates35
force-pushed
the
tsconfig-updates
branch
from
2a103ee
to
9f4f7b4
Compare
philbates35
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in 2aa6462 is resulting in a
vite.config.jsandvite.config.d.tsbeing generated which we don't want. To fix this, lets do the "solution" tsconfig approach as used by the create-vue project. This results in things like the following, all of which aren't enforced currently:process.cwd()invite.config.tsandsum.test.tsbut not in any src files such asapp.tsdocument.createElement()in src files such asapp.tsand insum.test.ts(because jsdom exists there) but not invite.config.tswhich is just pure node environment."".replaceAll()invite.config.tswhich should be allowed because we're using node 20.See: