some fixes in unix/Makefile #192

guberathome · 2025-01-04T06:13:37Z

minor stuff:

the build path was hardcoded, preventing it to be used from other directories
it looks like IO_SOURCE is meant to contain platform specific IO. Unfortunately the Makefile reset the variable even if it was already defined.
with that in place, the existing infrastructure can be used for other (cross)compilers like Zig
do not reset CC if if was already defined.
move options to top of Makefile which are meant to be set from the outside

platforms/unix/Makefile

platforms/zig-crossbuild/cross-compile.sh

guberathome · 2025-01-05T09:28:49Z

done, ready to be merged.

Please note I added a comment that this actually requires gnu make to work.

guberathome added 5 commits January 4, 2025 06:25

feature: allow unix/Makefile to be run from other directories

f2dc084

bugfix: do not reset IO_SOURCE if it's already defined

0254e3d

added ZIG as platform

eb4efb4

bugfix: do not reset CC is it was alreasy set from the outside

07586fc

bugfix: declare WIDTHOPT to be settable from outside

0ca09d7

philburk requested changes Jan 4, 2025

View reviewed changes

platforms/unix/Makefile Show resolved Hide resolved

platforms/zig-crossbuild/cross-compile.sh Outdated Show resolved Hide resolved

guberathome marked this pull request as draft January 4, 2025 20:36

from-codereview: removed zig builds

b274131

guberathome marked this pull request as ready for review January 5, 2025 09:28

guberathome mentioned this pull request Jan 5, 2025

Zig for (cross) compilation #194

Merged

docu: added required software to unix/Makefile

45212bd

guberathome mentioned this pull request Jan 5, 2025

fix fallback/stdio build #196

Merged

philburk approved these changes Jan 6, 2025

View reviewed changes

philburk merged commit ffeeda3 into philburk:master Jan 6, 2025
3 checks passed

guberathome deleted the zig-build branch January 6, 2025 07:14

Provide feedback