Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<open>InNewWindow commands #1047

Closed
alexherbo2 opened this issue May 1, 2014 · 11 comments
Closed

<open>InNewWindow commands #1047

alexherbo2 opened this issue May 1, 2014 · 11 comments

Comments

@alexherbo2
Copy link

We could use app mode for these ones.

@mrmr1993
Copy link
Contributor

mrmr1993 commented May 1, 2014

I'm sorry to be dense, but what does this mean? I'm not sure I know what 'app mode' is..

@alexherbo2
Copy link
Author

From man chromium

--app=URL
Runs URL in "app mode": with no browser toolbars.

@mrmr1993
Copy link
Contributor

mrmr1993 commented May 1, 2014

I can't find any part of the Chrome extensions API which allows us to access this functionality. Specifically, according to the chrome.windows API, we can query windows (chrome.windows.query) on whether they have type="app", but we can only create windows of type "normal", "popup", "panel" or "detached_panel", and the latter two are only different to "popup" when the --enable-panels flag set.

Unless I've missed something in the API, I don't think it is possible for us to do this.

@philc
Copy link
Owner

philc commented May 1, 2014

What's a representative use case this is ticket is intended to fulfill?

@alexherbo2
Copy link
Author

Enable me to use Chromium like I use browser with no tabs. That is replace <open>InNewTab commands with <open>InNewWindow and set in app mode.

@mrmr1993
Copy link
Contributor

mrmr1993 commented May 2, 2014

Wouldn't it make more sense to add an "open in new window" command, without replacing the existing tab commands? Then you could unbind the tab commands and bind this "open in new window command" in your options.

Along with this, we can trigger fullscreen mode from Vimium, so it might be worthwhile also creating an "open in new fullscreen window command" command, which you could, again, bind instead of the tab command. This feels like a reasonable solution to the problem to me.

@alexherbo2
Copy link
Author

Yes. It is what I mean.

@mrmr1993
Copy link
Contributor

mrmr1993 commented May 2, 2014

I've implemented the commands I described above as LinkHints.activateModeToOpenInNewWindow and LinkHints.activateModeToOpenInNewFullscreenWindow at PR #1049, in case you want to give it a try.

@alexherbo2
Copy link
Author

Thanks a lot !

Shame window.type.app is missing from the API though :|

@alexherbo2
Copy link
Author

How change the policy ‹ request new window › open page in a new window, instead of a new tab?

What to do when a website wants to open a new window:

hook global NewWindow <all_urls> OpenIn(Current|New)(Tab|Window)

@smblott-github
Copy link
Collaborator

Closing.
Old issue. Possible need for open in new window is known. Also happens to be in #1948.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants