Merge of lots of pull requests #1173
Conversation
1. isEmbed method should great than -1 2. flash player can blur through document.activeElement.blur()
Added LinkHints.activateModeToHover and LinkHints.unhoverLast to perform hovering. These are unbound by default. Also call LinkHints.unhoverLast automatically before hovering/ clicking the next link, to avoid permanently showing hover effects (eg. IMDb watchlist grid view mode).
I've had this in my personal fork since early 2013, and I think it's much better design to match the wraparound behavior of nextTab and previousTab in this way. I've noticed that the vast majority of my use cases involve wrapping. I also implemented moveTabToLeft and moveTabToRight, but even I don't have them mapped to anything. So I don't think it's necessary to merge that with upstream unless there's actual demand for it.
The use of Vomnibar commands with a numerical prefix > 1 is broken and non-trivial to fix. This patch introduces the `noRepeat` property for frontend commands, applying it to all Vomnibar commands and several others.
Implement `repeatLimit`, to prompt for confirmation before repeating a command a large number of times, and apply it to tab creation/deletion commands.
Use the `openUrlInCurrentTab` message to open bookmarklets so they are opened via `chrome.tabs.update` instead of an injected script element. This allows bookmarklets to open popups.
Scrolling is broken, effectively useless at present
Conflicts: content_scripts/vimium_frontend.coffee
This adds Vomnibar.activateEditUrl and Vomnibar.activateEditUrlInNewTab commands to edit the current URL in the Vomnibar.
Conflicts: background_scripts/commands.coffee content_scripts/link_hints.coffee
Conflicts: background_scripts/commands.coffee background_scripts/main.coffee content_scripts/link_hints.coffee
Conflicts: lib/dom_utils.coffee
Conflicts: background_scripts/commands.coffee
Conflicts: CREDITS background_scripts/commands.coffee
Conflicts: background_scripts/commands.coffee
Conflicts: CREDITS background_scripts/commands.coffee background_scripts/main.coffee content_scripts/link_hints.coffee manifest.json
Conflicts: background_scripts/main.coffee
mrmr1993
force-pushed
the
pr-compilation
branch
from
968ba50 to
3af0d93
Compare
|
@philc @smblott-github is there any chance of this getting merged before it diverges from master any more? It would fix more than 10% of the open issues. If so, (other than rebasing onto the current master) is there anything I should do to make it easier/cleaner to do so? |
|
Thanks, @mrmr1993. If you bump the PRs you think are important, or easy fixes, we'll take a look at them. But perhaps drip them in over time -- so, not all at once, please! |
|
Hi guys, I actually hit this PR because I saw a bunch of open issues and discovered this may have/should have closed them, but it appears since they didn't make it to master they are still open. Hopefully you can start dribbling these in and getting rid of issues that have been solved. Heck I'd manually go through and close the issues for things fixed by this that are resolved but maybe not in mainline if it'd help. My main reason for piping up is that open PRs are a form of technical debt that can be devastating, I use Salt Configuration Management a product of SaltStack in my day job, and they have so many open issues and a mess of PRs, even if I knew how to fix an issue, I'd have no guarantee my code would ever make it to mainline and they are getting PAID to maintain it for enterprise customers. |
This PR merges PR's #784, #844, #1004, #1023, #1032, #1049, #1050, #1082, #1086, #1104, #1111, #1128, #1131, #1139, #1140, #1161, #1162, #1166, #1169, #1172, #1177 onto the current master (although not necessarily in that order). This is a collection of (hopefully) the least objectionable PR's that are outstanding, mostly bugfixes and new
LinkHintsactions.This completely fixes issues #175, #301, #331, #484, #599, #776, #812, #888, #960, #967, #968, #980, #1001, #1047, #1080, #1093, #1096, #1109, #1126, #1144, #1156, #1165, #1171, and makes progress on several others (plus some unreported ones).