-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: edit the current URL in the omnibar #1004
New feature: edit the current URL in the omnibar #1004
Conversation
Often times when I'm working on sites I want to add a query string or modify the port number. The go up one level or root of the URL commands are nice but they don't alow you to add or remove specifics on the current URL. This adds two commands that act exactly like the normal onmibar open but populates the bar with the current URL. I picked `ge` as the default and `gE` as the default for the same in a new tab.
Bump |
Why not use the default command for editing the URL bar? |
Those commands do not work for me on my system. I also like the search provided by the vomnibar. I can not access the vomnibar features from the chrome address bar. When the chrome address bar take focus it highlights the entire string adding yet another keystroke to reach the end and increasing the chance of accidentally deleting the entire address. I found that staying in the vimium system allowed for a more optimized interface to editing the current URL. |
LGTM. I will merge this in soon. |
It seems like a shame to have two new commands for this use case. Another implementation is to have the current URL populated in the vomnibar when you press "o" (or "O" for new tab), and selected, so if you begin typing, it replaces what's in the Vomnibar. This affords the same experience to hitting Cmd+L in Chrome. What do you guys think? |
The only concern I can think of is if pressing "o" or "O" will always overwrite the X primary selection with the current URL for Linux users. I'm not sure if it will though; pressing Ctrl-L or clicking Chrome's location bar doesn't overwrite the X primary selection even though it selects the URL. |
I know many love that feature in FireFox and Chrome when you click the address bar. I however, curse and yell (vein popping out of head) when those kinds of user interface "enhancements" happen. So I like declarative commands and not implicit focus changes. In fact the awkward interface of the address bar is one of the core reasons I install plugins like vimium and vimperator. To be honest (not trying to knock the idea personally) but if the omnibar highlighted text on my behalf it's no different then the chrome address bar and hence why not just use that instead. Have 'o' map to focus the address bar. |
@sukima Chrome does not provide a way to bind a key to focus the address bar. |
@hagabaka try |
I've merged this. It looks good. Two new commands is better than pre-populating the vomnibar (in my view) which is just too in-your-face. |
Thanks! |
Tracked down some keybindings I was after under philc#1004 Added them to the main documentation.
This is awesome! 💯 |
Often times when I'm working on sites I want to add a query string or modify the port number. The go up one level or root of the URL commands are nice but they don't alow you to add or remove specifics on the current URL.
This adds two commands that act exactly like the normal onmibar open but populates the bar with the current URL.
I picked
ge
as the default andgE
as the default for the same in a new tab.