fix a bug and improve flash control #844
Conversation
loyalpartner
commented
May 17, 2013
loyalpartner
commented
- isEmbed method should great than -1
- flash player can blur through document.activeElement.blur()
1. isEmbed method should great than -1 2. flash player can blur through document.activeElement.blur()
| @@ -390,6 +390,10 @@ onKeydown = (event) -> | |||
| event.srcElement.blur() | |||
| exitInsertMode() | |||
| DomUtils.suppressEvent(event) | |||
| else if isEmbed(event.srcElement) and KeyboardUtils.isEscape(event) | |||
|
Looks promising, and nice bug fix. Can you tell me how this improves the handling of a flash embed by providing an example site and vimium's behavior before & after? |
|
bump |
Conflicts: content_scripts/vimium_frontend.coffee
| @@ -410,6 +414,7 @@ onKeydown = (event) -> | |||
| else if (isShowingHelpDialog && KeyboardUtils.isEscape(event)) | |||
| hideHelpDialog() | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Can we lose this extra empty line?
|
Bump, @loyalpartner. Can you provide an example and explanation, please? |
|
It makes the escape key blur flash objects when one is focused. Without this, the flash object receives the next keystroke, it re-focuses, an re-enables insert mode. Basically, this fixes insert mode for |
|
Thanks, @mrmr1993. Can you give me an example of a site where I can see this effect? Can you think of any use cases where this is the wrong thing to do? I'm thinking, for example, of that Facebook Messenger case in another issue where Facebook and vimium both want to handle the escape key. |
|
My go-to test was BBC iPlayer, ever since YouTube started supporting HTML5. Any website with embedded flash should work though. There are probably some examples that would break, but I think the solution I suggested on that issue could work here too. |
|
Fixed Regarding |
|
i'm sorry, i am busy for my work about this question,i found it works on windows and linux, but doesnt work on mac. 在 2014-10-25 23:25:12，"Stephen Blott" notifications@github.com 写道： Bump, @loyalpartner. Can you provide an example and explanation, please? — |
|
@loyalpartner: The most recent discussion of this is over in #1194. The current status is that it has been withdrawn. See #1194 as to why. Thanks for the original PR. It would be great if you could contribute to the ongoing discussion of this issue. |
