Fix tab restoration

[mrmr1993]

This adds the "sessions" permission to manifest.json, which enables actual tab restoration.

This PR should:

• fix History lost when using custom 'reopen closed tab' shortcut #1165
• fix Capital X (unclose last closed tab) should restore history #1069
• resolve history is removed after closing and reopenig a tab #872 (already closed)
• resolve u - open closed tab doesn't preserve history #133 (already closed)

[mrmr1993]

Rebased.

[smblott-github]

Excellent, thanks @mrmr1993.

Looks like the cost of this is:

• We need an extra permission; but, if we, then so be it.
• We lose the feature whereby certain non-vimium enabled tabs are skipped; but that's not obviously a great feature anyway.
• If the sessions permission is requested by an unpacked extension on an older chrome version which doesn't support it, then you get an error message on the Extensions page, but the extension does work. @mrmr1993: Do we know what happens in this case if the extension comes from the Chrome Store?

However, restoring tabs without their history was always a bit hokey. So this is great to have.

[mrmr1993]

I'll check on this and get back to you, I know nothing about the Chrome Web Store. @philc, do you know?

[philc]

@mrmr1993 I don't know what will happen in this case if Vimium is installed from the chrome store on an old version of chrome.

Out of curiosity, which version of Chrome was this introduced in?

[mrmr1993]

@philc Chrome 37, I believe

[hpurmann]

I'm still having this issue of not providing the tab's history when restoring it, using Vimium 1.45 installed from the Chrome Web Store. My Chrome is up-to-date (currently version 38.0.2125.122).

However, the permissions in the chrome://extensions tab seem fine (see screenshot).

[smblott-github]

I'm still having this issue of not providing the tab's history when restoring it, using Vimium 1.45 installed from the Chrome Web Store.

The fix is merged into master but not yet released. It'll be in in the next release, which should be in the coming weeks.

[hpurmann]

Ah ok. Thx for the fast response. So you are not using some model like git flow? It would be nice to have a development branch and a release branch (master) with the released versions. Then if such an issue is fixed we could just merge the hotfix branch into master and release a new version (e.g. 1.45.1, last version number increases). Releases would be more frequent.

What do you think?