Opening link in new window behaviour

[kul]

With the newest update of vimium i was no longer able to open links in new tabs by,

press f -> (let sayPC is one of the suggestions) press pC.

This used to work consistently till now. I have to now resort to F -> pc.

[devou]

+1 to kul. Bring it back, please.

[lavie]

+1 didn't even know about this feature and it makes so much sense.

[wting]

👍

[mrmr1993]

👍 I used this all the time as well. (Please don't hate me, I only wrote the commits which deleted the feature.) There is a PR fixing this at #1104.

[philc]

Any more support for this? While it's a cool feature, if it was really important, I'm surprised more people haven't complained since its demise. The reason it was deleted is because it caused problems for many people. See #850, #857, #697.

[vincentbernat]

I was also using this functionality a lot and I am missing it. If it was disturbing for some people, maybe use it as an option. From the above bug report, it just seems to be a documentation problem.

[mrmr1993]

@philc it seems that all those issues could have been avoided/quickly resolved if there had been documentation for it somewhere, without crippling the feature. Can you please revert (or merge #1104)?

[OlivierBlanvillain]

+1. I think it really makes sense to have a Shift/Ctrl behaviour when opening a link in this mode. By the way Chrome does something similar by default: when a link is focused, Enter opens it, Ctrl + Enter opens it in a new tab and Shift + Enter opens it in a new window (this matches the click behaviour).

[antonpetrovmain]

+1

[mrmr1993]

Apparently (see PR #1292) this has still been working in Windows the entire time.

The reason it was deleted is because it caused problems for many people. See #850, #857, #697.

@philc Only 3 people have had this issue (these two in #850 and this one in #857). #697 is actually the opposite issue; there are 3 people there for whom the feature stopped working and who want it back.

In total -- between #697, this issue and the guy from #1292 -- there are nearly 4 times as many (11) people who want this back having lost it and we're inconsistent across platforms. Can you please merge #1104 and end our pain?

[philc]

Will take a look shortly.
On Dec 9, 2014 6:39 AM, "Matthew Ryan" notifications@github.com wrote:

Apparently (see PR #1292 #1292)
this has still been working in Windows the entire time.

The reason it was deleted is because it caused problems for many people.
See #850 #850, #857
#857, #697
#697.

@philc https://github.com/philc Only 3 people have had this issue (these
#850 (comment) two
#850 (comment) in #850
#850 and this one
#857 (comment) in #857
#857). #697
#697 is actually the opposite
issue; there are 3 people there for whom the feature stopped working and
who want it back.

In total -- between #697 #697,
this issue and the guy from #1292
#1292 -- there are nearly 4 times
as many (11) people who want this back having lost it and we're
inconsistent across platforms. Can you please merge #1104
#1104 and end our pain?

—
Reply to this email directly or view it on GitHub
#1096 (comment).

[philc]

@mrmr1993 I don't feel that strongly either way. If you feel strongly about it, let's merge #1104 into the release after 1.46

[mrmr1993]

@philc the release is out now, can we merge #1104?

[maximbaz]

A month has passed.... is there anything, that blocks us from merging #1104?

/cc @philc, @mrmr1993

[smblott-github]

#1104 is merged.