Skip to content

Commit

Permalink
Re-introduce ctrl, shift keys as link hint mode modifiers
Browse files Browse the repository at this point in the history
This fixes philc#1096.
  • Loading branch information
mrmr1993 committed Jul 28, 2014
1 parent 9214719 commit 346c421
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion content_scripts/link_hints.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,25 @@ LinkHints =
if event.keyCode == keyCodes.shiftKey
@setOpenLinkMode(if @mode is OPEN_IN_CURRENT_TAB then OPEN_IN_NEW_BG_TAB else OPEN_IN_CURRENT_TAB)

handlerStack.push
keyup: (event) =>
return if (event.keyCode != keyCodes.shiftKey)
@setOpenLinkMode prev_mode if @isActive
handlerStack.remove()

else # event.keyCode == keyCodes.ctrlKey
@setOpenLinkMode(if @mode is OPEN_IN_NEW_FG_TAB then OPEN_IN_NEW_BG_TAB else OPEN_IN_NEW_FG_TAB)

handlerStack.push
keyup: (event) =>
return if (event.keyCode != keyCodes.ctrlKey)
@setOpenLinkMode prev_mode if @isActive
handlerStack.remove()

# TODO(philc): Ignore keys that have modifiers.
if (KeyboardUtils.isEscape(event))
@deactivateMode()
else
else if (event.keyCode != keyCodes.shiftKey and event.keyCode != keyCodes.ctrlKey)
keyResult = @getMarkerMatcher().matchHintsByKey(hintMarkers, event)
linksMatched = keyResult.linksMatched
delay = keyResult.delay ? 0
Expand Down

0 comments on commit 346c421

Please sign in to comment.