Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DOM injection on specific site #2997

Open
hanfeisun opened this issue Mar 27, 2018 · 2 comments
Open

Disable DOM injection on specific site #2997

hanfeisun opened this issue Mar 27, 2018 · 2 comments

Comments

@hanfeisun
Copy link

When I enable vimium on google payment center, some of their function will not work at all. The reason is that they use safeHTML check to avoid potential malicious DOM manipulation. And vimium will appended a tag _vimium-has-onclick-listener to the DOM, which will break their safeHTML checking.

I tried to disable vimium on that site, but that doesn't work. Even though all the keybindings are disabled, the DOM injection still happens, so the safeHTML still breaks.

Is there a way to also disable DOM injection on specific site?

@smblott-github
Copy link
Collaborator

Thanks, @hanfeisun. I imagine that took some time to track down!

This sounds plausible. We will need to find another mechanism for informing the Vimium Javascript context when a click listener is added to an element in the page Javascript context.

@smblott-github
Copy link
Collaborator

I disabled the offending injected (5745bb3) and push this as 1.63.3. This is a temporary fix.

smblott-github added a commit to smblott-github/vimium that referenced this issue Apr 2, 2018
5745bb3 disabled our detection of click
listeners added with `addEventListener` (see philc#2997 and philc#3002).

This PR proposes using the CSS class list to inform Vimium that an
element has a click listener (instead of a custom attribute).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants