Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus switches randanly after using Vomnibar.activateInNewTab command in chrome 72. #3242

Closed
terrell032 opened this issue Feb 9, 2019 · 3 comments · Fixed by #3246
Closed

Focus switches randanly after using Vomnibar.activateInNewTab command in chrome 72. #3242

terrell032 opened this issue Feb 9, 2019 · 3 comments · Fixed by #3246

Comments

@terrell032
Copy link

Issue appears on windows 10 64 bit chrome version 72.0.3626.96.
Previous version 71.0.3578.80 is OK.
After openning new tab through vomnibar, focus mostly stays on current tab, but also switch to the newly opened tab sometimes like previous version always do.
@ghost
Copy link

ghost commented Feb 14, 2019

I'm getting the same issue on Chrome Version 72.0.3626.96 (Official Build) (64-bit), macOS Mojave 10.14.3

@baotiao
Copy link

baotiao commented Feb 15, 2019

I'm getting the same issue on Chrome Version 72.0 macos Majave

gdh1995 added a commit to gdh1995/vimium that referenced this issue Feb 16, 2019
@gdh1995
delay window.focus() when needed
dc2bff8 
On Chrome, if an extension's content script call window.focus()
  during Port.onMessage handlers, then Chrome will activate the tab.
Therefore there's a race condition causing philc#3242.

In my tests, a `setTimeout` is just enough to avoid this activating.
@gdh1995 gdh1995 mentioned this issue Feb 16, 2019
Merged
@terrell032
Copy link
Author

@gdh1995 @smblott-github
Thanks! Happy to see this issue fixed.
But... I just noticed that the dates in release notes are incorrect...
Finally, I can have my chrome up to date...

@0xC0FFEE 0xC0FFEE mentioned this issue May 3, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

delay window.focus() when needed gdh1995/vimium
2 participants
@baotiao @terrell032