Fix createTab incognito and createTab window commands with no URLs on Firefox #3675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, user-defined mappings for
createTab incognito
andcreateTab window
with no URL parameters fail on Firefox, e.g.:This is because these commands try to call
chrome.windows.create
withabout:newtab
as a URL parameter, which is illegal in Firefox. The solution is to instead callchrome.windows.create
with the URL parameter omitted, which makes it default to the Firefox's home page (forcreateTab window
) orabout:privatebrowsing
(forcreateTab incognito
). A similar solution is already in place for the basiccreateTab
command:vimium/background_scripts/main.js
Lines 181 to 183 in bdf654a