Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that f and F show visible links #4407

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gitressa
Copy link

Description

Great add-on, it will make browsing so much faster, thanks!

After installing the add-on, I was reading the help page (?) but could not see how to find links. I normally use "search for links in text" via the ' character in Firefox.

https://support.mozilla.org/en-US/kb/search-contents-current-page-text-or-links#w_search-links-only

It was only by mistake that I pressed f and saw the links on the page highlighted with shortcuts, which is an even better solution for finding links.

So would it make sense to clarify that f and F show links on the help page?

PS. I also fixed a few instances where a line starts with a capital letter, since it looks like the style is to only start with small letters.

@allamedo
Copy link

@gitressa I think the descriptions at vimium/background_scripts/commands.js should also be updated.

@gitressa
Copy link
Author

Thanks @allamedo, I updated the background_scripts/commands.js file as well.

Copy link
Contributor

@VincentBarkman VincentBarkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No apparent issues from what I can see

Vincent A. Barkman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants