Fixes for Orion Browser #3610 #4432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hang on, sorry I just found an additional bug when using the |
|
Any news on this one? I want to help! I think I have some more bugs and I want to see if I can contribute. |
philg-dev
reviewed
Feb 6, 2025
| // Migration for v2.0.0: decode all values so that they're not JSON string encoded. | ||
| const newSettings = {}; | ||
| for (const [k, v] of Object.entries(settings)) { | ||
| // Most pre-2.0 settings were strings, but the global marks were stored as native values. See | ||
| // #4323. So check the setting value's type before migrating. | ||
| if (typeof v === "string") { | ||
| if (typeof v === "string" && isValidJSON(v)) { |
There was a problem hiding this comment.
This code will call JSON.parse(str) twice on every successful call instead of putting the try-catch directly where it's necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request has some reference to issue #3610. But mainly this pull request is so we can run Vimium in Orion. For those that don't know, Orion is a WebKit based browser that is attempting to support both Chrome and Firefox extensions alike.
I believe Vimium was working previously for the most part but then something to do with settings parsing broke it I believe. The issue I found was that WebKit's support for
JSON.parse()seems to have a few issues.There was a
^symbol invimium.cssthat WebKit'sJSON.parse()didn't know how to handle when iterating and parsing through the settings keys insettings.js: migrateSettingsIfNecessary(settings).WebKit's
JSON.parse()struggled again in the same iterator when given an item that was not a stringified JSON object. So a simple validation was added in so only stringified JSON objects would be parsed.After these fixes were made I tested it with Orion Version 0.99.126.4.1-beta (WebKit 618.1.2).
A small formatting fix was also made.