Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(completions): add tab favicon for better image quality #4533

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abelfubu
Copy link

Description

image

As many of you know, a significant number of users apply custom CSS to enhance their Vimium experience. While creating my own custom styling, I encountered a limitation with the Vomnibar: the favicon is always fetched at a 16px size. This fixed size makes resizing the icon challenging, as it can result in a blurry appearance.

image

This PR addresses this issue by fetching the tab's favicon URL directly when available, allowing for a higher-quality icon. If the favicon isn't available, the PR provides a fallback with an improved size, ensuring the icon looks sharp and visually appealing even when resized.

@UncleSnail
Copy link
Contributor

I can see the benefit of this.

I might be misunderstanding the code, but it looks like you have pushed the problem back by setting a new size of 64px. Imagining into the future, is there a potential that someone else will make a PR to change the new 64px size to something higher? In other words, is 64px also just an arbitrary size? If so, maybe we can find a way to get the size the CSS is actually trying to use.

Also, it looks like these changes might mean a 64px image is always being pulled now, even for users who use a 16px thumbnail, which would slow down the experience of the majority of existing users.

I completely agree that we should fix this issue so that we can have larger icons appear sharp for the users who want it, but I'm wondering if I'm understanding the code correctly and if so, if we can improve some of the downsides.

Thank you for your contribution.

@abelfubu abelfubu force-pushed the feature/vomnibar-results-favicon-size-setting branch from a0729d2 to d7f2ce3 Compare September 12, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants