Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clickable elements with class 'btn' #4566

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Oct 29, 2024

  1. Fix clickable elements with class 'btn'

    Fixes philc#3550
    
    Update `content_scripts/link_hints.js` to make elements with class 'btn' clickable.
    
    * Add logic to `getLocalHintsForElement` to check for class 'btn' and mark elements as clickable.
    
    ---
    
    For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/philc/vimium/issues/3550?shareId=XXXX-XXXX-XXXX-XXXX).
    ScottWilliamAnderson committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4656c1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    694ba53 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Update getLocalHintsForElement to check for class 'btn' and remove …

    …redundant check for class 'button'
    
    * Merge the if statement for 'button' and 'btn' classes
    * Remove redundant check for class 'button'
    ScottWilliamAnderson committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2b0030f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    35e1bc5 View commit details
    Browse the repository at this point in the history