Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Move global DSL type definitions into an index file. #93

Closed
wants to merge 15 commits into from

Conversation

philcockfield
Copy link
Owner

@philcockfield philcockfield commented Jul 16, 2016

Export the UIHarness DSL as global types.

@mention-bot
Copy link

@philcockfield, thanks for your PR! By analyzing the annotation information on this pull request, we identified @frederickfogerty to be a potential reviewer

@philcockfield
Copy link
Owner Author

Hey @frederickfogerty - figuring out how to move the Type Definitions you declared in the typescript.spec.tsx file into a place that they are globally picked up by the parent module.

I've copied them out into a /src/index.ts file, but can't seem to get them to get picked up globally by the TS compiler.

Any ideas?

@frederickfogerty
Copy link
Collaborator

Did you mean to make it index.d.ts, not index.ts?

@@ -76,7 +80,7 @@
"sinon": "^1.16.1",
"tslint": "^3.11.0",
"tslint-react": "^0.4.0",
"typescript": "^1.9.0-dev.20160617-1.0",
"typescript": "^2.1.0-dev.20160716",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet - new version. That has async/await I assume. Will update my other references to this too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, still open microsoft/TypeScript#9175

@philcockfield
Copy link
Owner Author

Hey @frederickfogerty, is this the kind of error you were seeing?

image

I blew away node_modules and re-installed, and it still did this. Any ideas?

@frederickfogerty
Copy link
Collaborator

@philcockfield nope, wasn't getting those errors - I wasn't getting any errors at all when running the ui-harness is dev mode

@frederickfogerty frederickfogerty deleted the phil-ts branch October 26, 2017 04:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants