Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setWhite() wrong color #2

Closed
mwittig opened this issue Dec 20, 2015 · 2 comments
Closed

setWhite() wrong color #2

mwittig opened this issue Dec 20, 2015 · 2 comments

Comments

@mwittig
Copy link

mwittig commented Dec 20, 2015

I am wondering about the RGB color values 0, 0, 0 set in the setWhite() function. Shouldn't it be 0xFF, 0xFF, 0xFF instead? See https://github.com/philip1986/iwy_master/blob/master/index.js#L238
mwittig added a commit to mwittig/iwy_master that referenced this issue Dec 20, 2015
@mwittig
Fix for issue philip1986#2 - setWhite() wrong color
3800bd9
@philip1986
Copy link
Owner

Since this._color is an instance of Color its not necessary to use hex values. But you are right for devices without an designated WHITE mode the values should be set max (255, 255, 255).

@philip1986
Copy link
Owner

Ok, I fixed the issue and published a new version 0.2.3 of the module

mwittig added a commit to philip1986/pimatic-led-light that referenced this issue Dec 22, 2015
@mwittig
* Updated dependencies: iwy_master 0.2.3 which conatins fix for whte-…
685e329 
…mode philip1986/iwy_master#2

* Fixed typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philip1986 @mwittig