Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milight setColor() raises 'color undefined' error #24

Closed
mwittig opened this issue Aug 11, 2015 · 1 comment
Closed

Milight setColor() raises 'color undefined' error #24

mwittig opened this issue Aug 11, 2015 · 1 comment

Comments

@mwittig
Copy link
Collaborator

mwittig commented Aug 11, 2015

I have just noticed the setColor() action as part of the Milight device class is broken. Looks like the code broke due to a previous merge. I'll provide a fix for this soon.

mwittig added a commit to mwittig/pimatic-led-light that referenced this issue Aug 11, 2015
philip1986 pushed a commit that referenced this issue Oct 3, 2015
Suggested fixes for issues #18, #19, and #24
philip1986 pushed a commit that referenced this issue Oct 4, 2015
… development_xento

# By Philip Patzer (15) and others
# Via philip1986 (4) and Philip Patzer (3)
* 'master' of github.com:philip1986/pimatic-led-light: (21 commits)
  include libudev-dev agin as travis dependency
  remove usb dependencies for blinkstick
  dirty workaround to run tests at travis
  libusb-1.0-0-dev
  add sudo libusb-1.0-0.dev as travis dependency
  add libudev-dev as travis dependency
  add .travis.yml
  bugfixes and unskip tests due to this fixes
  unskip test and adjust test case to actual behavior
  add test script to package.json
  Increased command delay to avoid drop-outs due to packet loss
  Suggested Fix for issue #19
  revert validation changes in iwy_master.coffee
  style
  MilightRF24Port workaround for testing
  add basic tests for iwy master and milight
  Fixed update of 'mode' property value as part of setColor() method.
  Fix for issue #18. Added section 'Installation' to document dependency on libudev-dev on Raspbian and Debian systems
  Fix for issue #24. Milight setColor() raises 'color undefined' error.
  Added DummyDevice.
  ...
@philip1986
Copy link
Owner

fixed by #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants