Development

[Xento]

No description provided.

[Xento]

I hope you can merge it. I tried to merge your changes into my fork, but I couldn't handle it.
I'm to unexperienced with the git commandline.

[Xento]

I think now I got everything correct ;-)

[philip1986]

Why you do it that way?

Wouldn't class MilightRF24 extends events.EventEmitter have the same effect?

[Xento]

Maybe
This was how I found it in an example.

I will change it and try it out.

2015-08-04 14:43 GMT+02:00 philip1986 notifications@github.com:

In devices/milightRF24.coffee
#23 (comment)
:

• MilightRF24::proto = events.EventEmitter.prototype

Why you do it that way?

Wouldn't class MilightRF24 extends events.EventEmitter have the same
effect?

—
Reply to this email directly or view it on GitHub
https://github.com/philip1986/pimatic-led-light/pull/23/files#r36182778.

[philip1986]

Could you please also add some commands to the code, specially how the classes MilightRF24 and MilightRF24Zone are interconnected.

[Xento]

I added some comments and improved the code

[Xento]

Are this enough comments?

[philip1986]

Yes, thanks a lot.
I will take some time to add some tests for it (I do it for all devices), because the complexity of the whole plugin makes it necessary.

[Xento]

When you will merge it?
Its running very smooth ;-)

[philip1986]

Sorry, its been a while. As I told you I like to have some tests for the plugin. So, I took your branch and add some basic ones. Would be nice if you extend then, e.g. when one device isn't in zone 0.
I also did a change about the configuration and initialization of milightRF24, because I didn't like the approach to set the port via the device config.

I am going to close this PR and open a new one with my modifications. Please have a look at it.

Cheers, Philip