Initial support for milight white bulbs #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #42 |
| color = Color(@color).rgb() | ||
| @device.sendCommands(nodeMilight.commands.rgbw.rgb255(color.r, color.g, color.b)) | ||
|
|
||
| if @config.type == "White" |
There was a problem hiding this comment.
I would prefer to have the bulb types as static var of the Milight class:
class Milight extends BaseLedLight
@BULB_TYPE:
WHITE: 'White'
COLOR: 'Color'
...
turnOn: ->
...
if @config.type is Milight.BULB_TYPE.WHITE
|
@philip1986 I don't think we should add a type property to the Milight device class as suggested by @bjornhij, but there should a new device class for this. Note, the contributed code does not handle dimming which works a lot different from RGBW dimming. With CW/WW LEDs the command set does not provide dimming value, but it provides commands to increase and decrease brightness. So, CW/WW need a UI class of its own. |
|
@mwittig ok I got your point and I agree. |
|
I've created a new MilightCWWW class. Still figuring out how I can use another UI class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color and brightness UI elements still there, but unusable.