Lofitime: A hifitime <-> chrono adapter #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philiplinden
had a problem deploying
to
github-pages
GitHub Actions
Failure
philiplinden
had a problem deploying
to
github-pages
GitHub Actions
Failure
| @@ -27,13 +24,137 @@ pub trait HifiDuration { | |||
| fn to_lofi_duration(&self) -> chrono::Duration; | |||
| } | |||
|
|
|||
| impl HifiDuration for hifitime::Duration { | |||
| fn to_lofi_duration(&self) -> chrono::Duration { | |||
| let (centuries, nanos) = self.to_parts(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Egui uses chrono for displaying dates and times, but I want to use hifitime for all of my internal timings. To adapt between chrono and hifitime datetimes and durations, I created a new crate called
lofitime.lofitimeadds a few traits that bridge the gap. I even wrote tests that pass!NOTE: For convenience,
chrono->hifitimeconversions are truncated to the millisecond.hifitime->chronoconversions use all of chrono's available precision.hifitime::Epochchrono::DateTime<Utc>HifiDateTime.to_lofi_utc()hifitime::Epochchrono::NaiveDateTimeHifiDateTime.to_lofi_naive()hifitime::Durationchrono::DurationHifiDateTime.to_lofi_duration()chrono::DateTimeorchrono::NaiveTimehifitime::EpochLofiDateTime.to_hifi_epoch()chrono::DateTimeorchrono::NaiveTimehifitime::EpochLofiDateTime.to_hifi_duration()This PR also contains some quality of life improvements like disabling CI workflows that are doomed to fail.