Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull sitemaps from disk #9

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

medoror
Copy link
Contributor

@medoror medoror commented Aug 4, 2024

  • Provide a directory of xml sitemaps on disk as an option to initializing SitemapToContentDatabase
  • Allow for multiple sitemap urls

@medoror
Copy link
Contributor Author

medoror commented Aug 4, 2024

Addresses issue #8 . This branch also allows for multiple sitemaps to be used via the filesystem or urls in the old manner

@philippe2803
Copy link
Owner

Cool idea.
Would you be able to add a unit test?

@medoror
Copy link
Contributor Author

medoror commented Aug 5, 2024

Cool idea.
Would you be able to add a unit test?

yea I can

* Provide a directory of xml sitemaps on disk as an option
  to initializing SitemapToContentDatabase
* Allow for multiple sitemap urls
@medoror medoror force-pushed the pull-sitemaps-from-disk branch from 5bcd5ba to 3911e78 Compare August 9, 2024 19:44
@medoror
Copy link
Contributor Author

medoror commented Aug 9, 2024

@philippe2803 Sorry was at a work event all week. I have properly implemented this feature with passing unit tests. Let me know what you think

@philippe2803
Copy link
Owner

@medoror just saw your message only now. Not sure how I missed it. Sorry about this. Running the tests now. I will merge automatically when the tests are finished

@philippe2803 philippe2803 merged commit b6986a0 into philippe2803:main Aug 24, 2024
5 checks passed
@philippe2803
Copy link
Owner

@medoror thanks for your contribution very much. It really adds something valuable. A couple of things I noticed after merging the PR (completely my fault for not noticing) that you should know in case you want to contribute more:

  • I use semantic release, so it gets uploaded to pipy automatically as long as the commit message is in the form "feat: or fix:". If this is not done, the release will not happen.
  • Unit tests should be made using Pytest.

You don't have to correct anything though, I made a a quick commit that follow the semantic release to trigger the release and it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants