Enable sanitizer on macOS #5809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📁 Repo: workflows
fhvwy
force-pushed
the
mark/use-sanitisers-on-macos
branch
from
4f3e257 to
ba4eea6
Compare
philippemnoel
requested review from
jkarthic,
fhvwy and
sardination
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #5809 +/- ##
==========================================
- Coverage 61.59% 55.91% -5.69%
==========================================
Files 168 194 +26
Lines 21457 25893 +4436
Branches 31 31
==========================================
+ Hits 13217 14477 +1260
- Misses 8028 11204 +3176
Partials 212 212
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
fhvwy
force-pushed
the
mark/use-sanitisers-on-macos
branch
from
ba4eea6 to
e60d9b8
Compare
Protocol End-to-End Streaming Test Results - 2022_03_10@17-31-41 UTCResults compared to branch devExperiment 0 - Network conditions: normalExperiment metadata - Expand hereExperiment metadata:
Experiment results - Expand hereSUMMARY OF MOST INTERESTING METRICS:
CLIENT METRICS:
SERVER METRICS:
Experiment 1 - Network conditions: 1Mbit,none,noneExperiment metadata - Expand hereExperiment metadata:
Experiment results - Expand hereSUMMARY OF MOST INTERESTING METRICS:
CLIENT METRICS:
SERVER METRICS:
Experiment 2 - Network conditions: 1Mbit,none,0.1Experiment metadata - Expand hereExperiment metadata:
Experiment results - Expand hereSUMMARY OF MOST INTERESTING METRICS:
CLIENT METRICS:
SERVER METRICS:
Experiment 3 - Network conditions: 1Mbit,100,0.1Experiment metadata - Expand hereExperiment metadata:
Experiment results - Expand hereSUMMARY OF MOST INTERESTING METRICS:
CLIENT METRICS:
SERVER METRICS:
Results compared to branch mark/use-sanitisers-on-macosExperiment 0 - Network conditions: normalExperiment metadata - Expand hereExperiment metadata:
Experiment results - Expand hereSUMMARY OF MOST INTERESTING METRICS:
CLIENT METRICS:
SERVER METRICS:
Experiment 1 - Network conditions: 1Mbit,none,noneExperiment metadata - Expand hereExperiment metadata:
Experiment results - Expand hereSUMMARY OF MOST INTERESTING METRICS:
CLIENT METRICS:
SERVER METRICS:
Experiment 2 - Network conditions: 1Mbit,none,0.1Experiment metadata - Expand hereExperiment metadata:
Experiment results - Expand hereSUMMARY OF MOST INTERESTING METRICS:
CLIENT METRICS:
SERVER METRICS:
Experiment 3 - Network conditions: 1Mbit,100,0.1Experiment metadata - Expand hereExperiment metadata:
Experiment results - Expand hereSUMMARY OF MOST INTERESTING METRICS:
CLIENT METRICS:
SERVER METRICS:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
This is a small improvement to our CI that @fhvwy did a while back, and we never merged/finished. The fix is described here:
google/sanitizers#1026
Need to explicitly specify
detect_leakson macOS, and useclang++for it to work.