more options for multi_find_all #31
Conversation
MultiEditUtils.py
Outdated
| newRegions.append(region) | ||
|
|
||
| if word: | ||
| deleted = [] |
There was a problem hiding this comment.
Can you extract Lines 24 to 27 into an inline function which takes a region as a parameter and returns a boolean indicating whether the region should be ignored or not. Then, we do not need the deleted list variable and could call said function directly in the for comprehension in Line 28.
There was a problem hiding this comment.
Thank you for your contribution! Honestly, I did not use the multi find all functionality yet (it was a PR from another contributor), but with these new features, I can see myself using it :)
However, I decided to not add standard keybindings to ST packages anymore. The likelihood that such keybindings conflict with existing, user-specific keybindings is very high, resulting in a poor user experience. Can you adapt your PR so that the keybindings are only suggested in the README and not added by default in the keymap files?
Also feel free to add the commands to the ST menu.
MultiEditUtils.py
Outdated
| newRegions = [region for region in newRegions if region not in deleted] | ||
|
|
||
| if ignore_comments: | ||
| deleted = [] |
There was a problem hiding this comment.
Same here from Line 31 to 36.
…mmand palette, made keybindings inactive for these commands, updated readme
Default (Linux).sublime-keymap
Outdated
| // multi find all - the first is the same behaviour as old [alt+f3] | ||
| { "keys": ["alt+f3", "alt+f3"], "command": "find_all_under"}, | ||
| // Multi Find All example keybindings, uncomment to activate | ||
|
|
There was a problem hiding this comment.
All keybindings are inactive this way
Default (Linux).sublime-keymap
Outdated
| // multi find all - the first is the same behaviour as old [alt+f3] | ||
| { "keys": ["alt+f3", "alt+f3"], "command": "find_all_under"}, | ||
| // Multi Find All example keybindings, uncomment to activate | ||
|
|
There was a problem hiding this comment.
All keybindings are inactive this way
| @@ -8,6 +8,6 @@ | |||
| { "command": "split_selection", "caption" : "MultiEditUtils: Split selection" }, | |||
| { "command": "strip_selection", "caption" : "MultiEditUtils: Strip Selection" }, | |||
| { "command": "remove_empty_regions", "caption" : "MultiEditUtils: Remove Empty Regions" }, | |||
| { "command": "multi_find_all", "caption" : "MultiEditUtils: Multi FindAll" }, | |||
| { "command": "multi_find_menu", "caption" : "MultiEditUtils: Multi FindAll" }, | |||
There was a problem hiding this comment.
Instead of adding all commands(they're a lot) it launches a mini-menu where you can choose
MultiEditUtils.py
Outdated
|
|
||
| # filter selections in order to exclude duplicates since it can hang | ||
| # Sublime if search is performed on dozens of selections, this doesn't | ||
| # happen with built-in command because it works on a single selection |
There was a problem hiding this comment.
I added this section because it was a bit hang-friendly when repeating searches over previous searches and too many selections, now you can do stuff like performing multiple searches over each other for different selections and with different commands
MultiEditUtils.py
Outdated
| if view.substr(view.word(region)).lower() not in selected_words: | ||
| deleted.append(region) | ||
| deleted = [region for region in newRegions | ||
| if view.substr(view.word(region)).lower() not in selected_words] | ||
| newRegions = [region for region in newRegions if region not in deleted] | ||
|
|
There was a problem hiding this comment.
that's the best I could come with
|
|
||
| for region in newRegions: | ||
| view.sel().add(region) | ||
|
|
||
| class MultiFindAllRegexCommand(sublime_plugin.TextCommand): | ||
|
|
There was a problem hiding this comment.
This is a new command, additive or subtractive, it works on top of any selection/searches you made
| sublime.active_window().show_input_panel(c, "", self.on_done, None, None) | ||
|
|
||
| class MultiFindMenuCommand(sublime_plugin.TextCommand): | ||
|
|
There was a problem hiding this comment.
This is the menu from the command palette
MultiEditUtils.py
Outdated
| "Find All Case + Word -", | ||
| "Find All Case - Word +", | ||
| "Find All Case - Word -", | ||
| "Find All Case + Word + Ignore Comments)", |
There was a problem hiding this comment.
Should probably be (Ignore Comments).
There was a problem hiding this comment.
Oops.. thanks! fixed and pushed
No description provided.