fix: scale down runners (#905)

* fix: scale down runners * fix: scale down runners
philips-labs · Jun 17, 2021 · f024cda · f024cda
1 parent 4afc1cb
commit f024cda
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/modules/runners/lambdas/runners/src/scale-runners/gh-auth.ts b/modules/runners/lambdas/runners/src/scale-runners/gh-auth.ts
@@ -46,13 +46,14 @@ export async function createGithubAuth(
   const appId: number = parseInt(process.env.GITHUB_APP_ID as string);
   const clientId = process.env.GITHUB_APP_CLIENT_ID as string;
 
-  const authOptions: StrategyOptions = {
+  let authOptions: StrategyOptions = {
     appId,
     privateKey,
-    installationId,
     clientId,
     clientSecret,
   };
+  if (installationId) authOptions = { ...authOptions, installationId };
+
   console.debug(ghesApiUrl);
   if (ghesApiUrl) {
     authOptions.request = request.defaults({
@@ -61,9 +62,4 @@ export async function createGithubAuth(
   }
   const result = (await createAppAuth(authOptions)({ type: authType })) as AppAuthentication;
   return result;
-  // if (result.type == 'oauth-app') {
-  //   return result;
-  // } else {
-  //   throw Error(`Authentication type ${authType} is not`);
-  // }
 }