Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runners): propagate var.runner_ec2_tags to EC2 volumes #2985

Merged
merged 2 commits into from
Mar 1, 2023
Merged

fix(runners): propagate var.runner_ec2_tags to EC2 volumes #2985

merged 2 commits into from
Mar 1, 2023

Conversation

v-rosa
Copy link
Contributor

@v-rosa v-rosa commented Feb 22, 2023

@v-rosa v-rosa mentioned this pull request Feb 22, 2023
Closed
@v-rosa v-rosa changed the title propagate var.runner_ec2_tags to EC2 volumes fix(runners) propagate var.runner_ec2_tags to EC2 volumes Feb 22, 2023
@v-rosa v-rosa changed the title fix(runners) propagate var.runner_ec2_tags to EC2 volumes fix(runners): propagate var.runner_ec2_tags to EC2 volumes Feb 22, 2023
@v-rosa v-rosa force-pushed the propagate-ec2-tags-to-volumes branch from d6b3f7b to ddd7b11 Compare February 22, 2023 11:55
@npalm npalm self-requested a review February 23, 2023 22:33
npalm
npalm requested changes Feb 24, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@v-rosa v-rosa force-pushed the propagate-ec2-tags-to-volumes branch from ddd7b11 to e0b4b47 Compare February 24, 2023 11:08
npalm
npalm approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-rosa thanks for your contribution and providing the fix!

@npalm npalm merged commit a9b1fa8 into philips-labs:main Mar 1, 2023
@forest-releaser forest-releaser bot mentioned this pull request Mar 1, 2023
Merged
@forest-releaser forest-releaser bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm npalm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-rosa @npalm