Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Set default lambda node runtime to 18x on arm64 #2763

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Conversation

npalm
Copy link
Member

@npalm npalm commented Dec 13, 2022

  • Update node runtime to node18.x (LTS)
  • Update default runtime to ARM

- Update node runtime to node18.x (LTS)
- Update default runtime to ARM
@npalm
Copy link
Member Author

npalm commented Dec 13, 2022

Verefied with mult runner example

@npalm npalm marked this pull request as draft December 13, 2022 17:33
@npalm npalm marked this pull request as ready for review December 13, 2022 21:57
runs-on: ubuntu-latest
strategy:
matrix:
node: [18]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to make this an input?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once needed. Preferable only one version.

@npalm npalm merged commit 06f511f into next Dec 14, 2022
@npalm npalm deleted the feat/bump-node branch December 14, 2022 07:45
npalm added a commit that referenced this pull request Dec 28, 2022
* feat!: Set default lambda node runtime to 18x on arm64

- Update node runtime to node18.x (LTS)
- Update default runtime to ARM

* upgrade terrafrom versions
npalm added a commit that referenced this pull request Dec 28, 2022
* feat!: Set default lambda node runtime to 18x on arm64

- Update node runtime to node18.x (LTS)
- Update default runtime to ARM

* upgrade terrafrom versions
npalm added a commit that referenced this pull request Dec 28, 2022
* feat!: Set default lambda node runtime to 18x on arm64

- Update node runtime to node18.x (LTS)
- Update default runtime to ARM

* upgrade terrafrom versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants