chore: fix test and add vscode workspace config #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
npalm
commented
Aug 9, 2023
•
npalm
commented
- fix for randomly failing unit test after merging feat(runners): add configurable eviction strategy to idle config #3375
- add workspace config for vscode
- increase coverage
npalm
force-pushed
the
npalm/fix/unit-test-scale-down
branch
from
3d28fb2 to
3021367
Compare
npalm
force-pushed
the
npalm/fix/unit-test-scale-down
branch
from
3021367 to
26e3565
Compare
maschwenk
reviewed
Aug 9, 2023
| @@ -398,6 +396,7 @@ describe('scaleDown', () => { | |||
| idleCount: 3, | |||
| cron: '* * * * * *', | |||
| timeZone: 'Europe/Amsterdam', | |||
| evictionStrategy: 'oldest_first', | |||
There was a problem hiding this comment.
I was specifically trying not to set this because I wanted to ensure that providing no value still defaulted to the right value. Would I make sense to make the SCALE_DOWN_CONFIG as injectable at the method level to make it easier to test? Mutating process.env in tests is just asking for trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.