[WIP] Secondary instance type #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Secondary instance type for spot * log error for runInstances call
|
@Kostiantyn-Vorobiov just wondering, did you had time to make any progress on the PR? |
Closed
|
@npalm I've tested code with callback and that works fine, but I'm stuck with fixing unit tests for new functions. I put this on hold for now due to overload and lack of JS knowledge. The last commit has my try with promises instead of callbacks and I'm also failed with fixing unit tests for that. Please take a look if you have time |
|
@Kostiantyn-Vorobiov thanks for the effort, we will have a look |
npalm
force-pushed
the
develop
branch
3 times, most recently
from
9abd8d0
to
b957e26
Compare
|
@Kostiantyn-Vorobiov thanks for your contribution. I will close the PR. A list of alternative instances can be provided. We are right now busy with replacing the run instances by create fleet API in #1556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secondary instance type for spot
log error for runInstances call