Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variable "volume_size" #830 #839

Merged
merged 2 commits into from
May 21, 2021
Merged

variable "volume_size" #830 #839

merged 2 commits into from
May 21, 2021

Conversation

kuvaldini
Copy link
Contributor

Closes #830

@kuvaldini kuvaldini mentioned this pull request May 19, 2021
Closed
@npalm npalm self-requested a review May 21, 2021 12:47
npalm
npalm approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@npalm npalm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuvaldini Thanks!

npalm
npalm requested changes May 21, 2021
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you run a terraform format, see also build log. Change is good

@kuvaldini
Copy link
Contributor Author

@npalm done, but i better like column formated code - easier to read

@kuvaldini
terraform fmt
223e02e 
Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
@JeroenKnoops JeroenKnoops merged commit 81ade92 into philips-labs:develop May 21, 2021
@kuvaldini kuvaldini deleted the volume_size branch May 31, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm npalm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"No space left on device" during heavy matrix workloads
3 participants
@kuvaldini @npalm @JeroenKnoops