Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make module lambda-download fail when wrong tag is set #840

Merged
merged 1 commit into from
May 21, 2021

Conversation

kuvaldini
Copy link
Contributor

@kuvaldini kuvaldini commented May 19, 2021

Currently output zip file contains text "404 Not found" and terraform apply reports success

Closes #838

Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
@kuvaldini
Copy link
Contributor Author

@npalm please take a look

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuvaldini Thanks

@npalm npalm merged commit 6d31735 into philips-labs:develop May 21, 2021
npalm pushed a commit that referenced this pull request May 21, 2021
Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
@kuvaldini
Copy link
Contributor Author

You are welcome. Thank you for a cool repo.

@kuvaldini kuvaldini deleted the curl-f branch May 31, 2021 23:04
npalm pushed a commit that referenced this pull request Jun 1, 2021
Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
forest-releaser bot pushed a commit that referenced this pull request Jun 1, 2021
### [0.13.1](v0.13.0...v0.13.1) (2021-06-01)

### Bug Fixes

* .gitignore for 'secrets.auto.tfvars' ([38d7df0](38d7df0))
* Add some essential dependecies on ubuntu example ([0079d16](0079d16))
* fail to download wrong tag of lambda ([#840](#840)) ([1112ca8](1112ca8))
* increase runner sync lambda memory setting and upgrade npm dependencies ([#844](#844)) ([b9e36e9](b9e36e9))
* revert dependency updates on runner module ([#784](#784)) ([76cdbe3](76cdbe3))
* ubuntu example runner_log_files variable ([5b3fc5b](5b3fc5b))
* ubuntu example to log syslog instead of messages ([#785](#785)) ([fb3e5d2](fb3e5d2))
* Update ubuntu example with assume_role comment ([2478daf](2478daf))
* upgrade runner module to support upgrade octokit auth-app ([#786](#786)) ([e110318](e110318))
* **docs:** fix variable name create_service_linked_role_spot in readme ([#750](#750)) ([42b0427](42b0427)), closes [#736](#736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants