Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bash completion support to amp-devcontainer #581

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Sep 26, 2024

Pull Request

Description of changes

This PR adds support for bash completion to amp-devcontainer-cpp and amp-devcontainer-rust

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner September 26, 2024 08:16
Copy link
Contributor

github-actions bot commented Sep 26, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.06s
✅ DOCKERFILE hadolint 2 0 0.47s
✅ GHERKIN gherkin-lint 2 0 0.65s
✅ JSON npm-package-json-lint yes no 0.44s
✅ JSON prettier 15 2 0 0.78s
✅ JSON v8r 14 0 15.78s
✅ MARKDOWN markdownlint 8 0 0 0.87s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.21s
✅ REPOSITORY checkov yes no 17.93s
✅ REPOSITORY gitleaks yes no 0.38s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.41s
✅ REPOSITORY secretlint yes no 1.18s
✅ REPOSITORY syft yes no 0.42s
✅ REPOSITORY trivy yes no 6.84s
✅ REPOSITORY trivy-sbom yes no 0.86s
✅ REPOSITORY trufflehog yes no 3.0s
✅ SPELL lychee 54 0 1.67s
✅ YAML prettier 21 0 0 0.93s
✅ YAML v8r 21 0 14.91s
✅ YAML yamllint 21 0 0.46s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Test Results

 2 files  ±0   2 suites  ±0   53s ⏱️ +2s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 964294f. ± Comparison against base commit cc9380c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:5540066fb22f130c7ef4d8a2c9661839dad5bf3d00713c16c0513731a9847a9e

OS/Platform Previous Size Current Size Delta
linux/amd64 433.13M 427.44M -5.70M (-1.31%)
linux/arm64 572.34M 566.88M -5.47M (-0.95%)

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:4f7b9f68f51f234c3427fdf8e65b046952e0699217c0b898f460f44fb82ef4be

OS/Platform Previous Size Current Size Delta
linux/amd64 653.79M 646.50M -7.30M (-1.12%)
linux/arm64 646.22M 639.07M -7.15M (-1.11%)

Copy link

sonarcloud bot commented Sep 28, 2024

@rjaegers rjaegers added this pull request to the merge queue Sep 28, 2024
Merged via the queue into main with commit 063e1bb Sep 28, 2024
20 checks passed
@rjaegers rjaegers deleted the feature/add-bash-completion branch September 28, 2024 20:46
Copy link
Contributor

Pull Request Report (#581)

Static measures

Description Value
Number of added lines 8
Number of deleted lines 2
Number of changed files 4
Number of commits 3
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 2.5 Days
Time that was spend on the branch before the PR was created 38.8 Min
Time that was spend on the branch before the PR was merged 2.5 Days
Time to merge after last review 2.5 Days

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 21.3 Min
Total time spend in last status check run on PR 10.3 Hours

Copy link
Contributor

github-actions bot commented Oct 9, 2024

🎉 Hooray! The changes in this pull request went live with the release of v5.3.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants