feat: merge upstream changes #126

richardapeters · 2023-05-03T09:45:52Z

No description provided.

UartStmDuplexDma: Disable DMA reception on destructor (cherry picked from commit 6b0edbbff0212e2c5dfca9361aa912a8513d9105)

… listed in RM0410, Table 28 UartStmDuplexDma: Fix default DMA channels for RX as listed in RM0410, Table 28 (cherry picked from commit 354b5164c5f37d702ea1e509e38d08e498a58280)

…revent core/bus lock up DmaStm: Disable interrupts on DMA stop transfer to prevent core/bus lock up (cherry picked from commit e1cf4a456a6aae420523d99917137965756da0b8)

… to services::Gap interface (cherry picked from commit f5da21bbee6503a0a08e5aeeedbda28b96ae0468)

…ervices::Gap GapPeripheralSt updated to use the new services::Gap (cherry picked from commit 701f391266a3e5ae4d551aa1d548b8eea0f66eb6)

Implement GapPeripheralSt::SetSecurityMode (cherry picked from commit ffb2d8b4ee2d40bf1e4e71015e448f5591973ced)

HalSt updated according the GATT interface (cherry picked from commit c809b11676121f0c12eea92b4b0a2f74755e9829)

(cherry picked from commit fda9e2f0b00dc03582cb6769d1daff87ecb69ffe)

(cherry picked from commit b0efe1ff8357a2238573eb75ae35fa1757f5bce2)

Added getters to GapPeripheralSt (cherry picked from commit ff76186ed29060327a4b9bfd42362b94c7dbea0b)

(cherry picked from commit ec30ab95a14f76e5a0104fe3582fce536f54973b)

- Common logic between central and peripheral was moved to a base class (GapSt) - GAP Central implemented - Privacy implemented for central (it was already implemented for peripheral)

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

hal_st/middlewares/ble_middleware/GapCentralSt.cpp

…-lib

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

hal_st/middlewares/ble_middleware/GapCentralSt.cpp

hal_st/middlewares/ble_middleware/GapPeripheralSt.hpp

hal_st/middlewares/ble_middleware/GapSt.cpp

github-actions · 2023-05-03T09:51:44Z

🦙 MegaLinter status: ⚠️ WARNING

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ ACTION	actionlint	5		0	1.29s
⚠️ MARKDOWN	markdownlint	20	14	2	0.97s
⚠️ MARKDOWN	markdown-link-check	20		13	29.36s
✅ MARKDOWN	markdown-table-formatter	20	14	0	0.42s
✅ REPOSITORY	checkov	yes		no	22.46s
✅ REPOSITORY	dustilock	yes		no	0.04s
✅ REPOSITORY	gitleaks	yes		no	94.9s
✅ REPOSITORY	git_diff	yes		no	0.11s
✅ REPOSITORY	secretlint	yes		no	34.76s
✅ REPOSITORY	syft	yes		no	0.5s
✅ REPOSITORY	trivy	yes		no	7.08s
✅ SPELL	misspell	44	2	0	0.26s
✅ XML	xmllint	17	0	0	0.17s
✅ YAML	prettier	7	1	0	0.8s
✅ YAML	v8r	7		0	7.69s
✅ YAML	yamllint	7		0	0.28s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

hal_st/instantiations/NucleoUi.hpp

hal_st/middlewares/ble_middleware/GapSt.cpp

hal_st/middlewares/ble_middleware/GattServerSt.cpp

hal_st/middlewares/ble_middleware/GattServerSt.hpp

hal_st/middlewares/ble_middleware/TracingGapCentralSt.cpp

hal_st/middlewares/cococo_modifications.md

hal_st/stm32fxxx/UartStmDuplexDma.cpp

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

examples/blink/Main.cpp

hal_st/middlewares/ble_middleware/TracingGapCentralSt.cpp

hal_st/middlewares/ble_middleware/TracingGapCentralSt.hpp

hal_st/stm32fxxx/DmaStm.cpp

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

hal_st/stm32fxxx/DmaStm.cpp

…it selects the wrong clang format config

andjordan and others added 13 commits May 3, 2023 09:48

Merged PR 10874: UartStmDuplexDma: Disable DMA reception on destructor

b0cedf5

UartStmDuplexDma: Disable DMA reception on destructor (cherry picked from commit 6b0edbbff0212e2c5dfca9361aa912a8513d9105)

Merged PR 10894: UartStmDuplexDma: Fix default DMA channels for RX as…

d3ddf19

… listed in RM0410, Table 28 UartStmDuplexDma: Fix default DMA channels for RX as listed in RM0410, Table 28 (cherry picked from commit 354b5164c5f37d702ea1e509e38d08e498a58280)

Merged PR 10899: DmaStm: Disable interrupts on DMA stop transfer to p…

d240171

…revent core/bus lock up DmaStm: Disable interrupts on DMA stop transfer to prevent core/bus lock up (cherry picked from commit e1cf4a456a6aae420523d99917137965756da0b8)

Merged PR 10988: Update security related GAP interfaces after changes…

6c1b0f7

… to services::Gap interface (cherry picked from commit f5da21bbee6503a0a08e5aeeedbda28b96ae0468)

Merged PR 10989: [ECR] - GapPeripheralSt changed to use the updated s…

6d75f58

…ervices::Gap GapPeripheralSt updated to use the new services::Gap (cherry picked from commit 701f391266a3e5ae4d551aa1d548b8eea0f66eb6)

Merged PR 11019: Implement GapPeripheralSt::SetSecurityMode

5d566f7

Implement GapPeripheralSt::SetSecurityMode (cherry picked from commit ffb2d8b4ee2d40bf1e4e71015e448f5591973ced)

Merged PR 11085: [ECR] HalSt updated according the GATT interface

8a24afb

HalSt updated according the GATT interface (cherry picked from commit c809b11676121f0c12eea92b4b0a2f74755e9829)

Merged PR 11239: fix gap device name accessibility and size limit

aa61241

(cherry picked from commit fda9e2f0b00dc03582cb6769d1daff87ecb69ffe)

Merged PR 11280: Gap device name and device privacy changes

1c46233

(cherry picked from commit b0efe1ff8357a2238573eb75ae35fa1757f5bce2)

Merged PR 11328: Added getters to GapPeripheralSt

eebf835

Added getters to GapPeripheralSt (cherry picked from commit ff76186ed29060327a4b9bfd42362b94c7dbea0b)

Merged PR 11353: apply st patch

3fd25b2

(cherry picked from commit ec30ab95a14f76e5a0104fe3582fce536f54973b)

Merged PR 11227: [ECR] GAP Central implementation

0abafb1

- Common logic between central and peripheral was moved to a base class (GapSt) - GAP Central implemented - Privacy implemented for central (it was already implemented for peripheral)

hal_st/middlewares/ble_middleware/GapSt.hpp: Remove incorrect include

3fd2720

richardapeters requested a review from a team as a code owner May 3, 2023 09:45

github-actions bot reviewed May 3, 2023

View reviewed changes

CMakeLists: temporarily use feature/merge-tfs from amp-embedded-infra…

fe3bcfb

…-lib

github-actions bot reviewed May 3, 2023

View reviewed changes

Apply clang-format

3124e63

github-actions bot reviewed May 3, 2023

View reviewed changes

daantimmer reviewed May 4, 2023

View reviewed changes

hal_st/middlewares/cococo_modifications.md Outdated Show resolved Hide resolved

hal_st/stm32fxxx/UartStmDuplexDma.cpp Show resolved Hide resolved

Remove project name from modifications.md

c59fa48

richardapeters requested a review from daantimmer May 4, 2023 06:45

github-actions bot reviewed May 4, 2023

View reviewed changes

Remove project name from modifications.md

dd921dd

github-actions bot reviewed May 4, 2023

View reviewed changes

richardapeters added 2 commits May 4, 2023 09:31

.gitgub/workflows/linting-formatting.yml: Disable formatting because …

4a89700

…it selects the wrong clang format config

CMakeLists: Update amp-embedded-infra-lib tag used

3409512

daantimmer approved these changes May 4, 2023

View reviewed changes

richardapeters merged commit 1546f51 into main May 4, 2023

richardapeters deleted the feature/merge-tfs branch May 4, 2023 08:34

rjaegers mentioned this pull request May 4, 2023

chore(main): release 2.1.0 #119

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: merge upstream changes #126

feat: merge upstream changes #126

richardapeters commented May 3, 2023

github-actions bot left a comment

github-actions bot left a comment

github-actions bot commented May 3, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

feat: merge upstream changes #126

feat: merge upstream changes #126

Conversation

richardapeters commented May 3, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented May 3, 2023 • edited Loading

🦙 MegaLinter status: ⚠️ WARNING

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented May 3, 2023 •

edited

Loading