Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

catch recursive exception of apm failing #13

Merged
merged 1 commit into from
Oct 19, 2018
Merged

catch recursive exception of apm failing #13

merged 1 commit into from
Oct 19, 2018

Conversation

philkra
Copy link
Owner

@philkra philkra commented Oct 18, 2018

should fix the issue #9

@philkra
Copy link
Owner Author

philkra commented Oct 18, 2018

@jblotus would you mind reviewing?

@philkra philkra mentioned this pull request Oct 18, 2018
Closed
jblotus
jblotus approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@jblotus jblotus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only thing that comes to mind as a potential issue is if people need to call Log with different channels / severity levels. For most cases this is probably just fine.

@philkra philkra merged commit 7285543 into master Oct 19, 2018
@philkra
Copy link
Owner Author

philkra commented Oct 19, 2018

I agree that there is no flexibility in the log severity level, but I guess semantically error should be the most accurate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jblotus jblotus jblotus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philkra @jblotus