Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring vocab module and fix potentially broken methods. #60

Closed
9 tasks done
filippodebortoli opened this issue Feb 15, 2023 · 0 comments · Fixed by #67
Closed
9 tasks done

Refactoring vocab module and fix potentially broken methods. #60

filippodebortoli opened this issue Feb 15, 2023 · 0 comments · Fixed by #67
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@filippodebortoli
Copy link
Collaborator

filippodebortoli commented Feb 15, 2023

I opened the broken-tests-vocabulary branch on my fork. I introduced a few tests in the vocab module that are currently failing:

  • vocab::test_is_xsd_datatype
  • vocab::test_namespace_in_entity_for_iri
  • vocab::test_to_built_in_entity

In addition, I left a few additional TODOs throughout the module:

  • evaluate if vocab::WithIRI could be moved to model or potentially into a new iri module together with model::IRI and model::ForIRI
  • evaluate if vocab::IRIString can be deprecated and replaced by model::IRI
  • fix vocab::to_built_in_entity to make the corresponding test pass
  • fix vocab::entity_for_iri to make the corresponding test pass
  • fix vocab::is_xsd_datatype to make the corresponding test pass

Already present TODOs:

  • implement Meta::all() for vocab::Vocab

I consider these to be potential bugs (hence the labels).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
1 participant