Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring vocab module and fix potentially broken methods. #61

Closed
wants to merge 39 commits into from
Closed

Refactoring vocab module and fix potentially broken methods. #61

wants to merge 39 commits into from

Conversation

filippodebortoli
Copy link
Collaborator

This relates to #60 and introduces the tests therein mentioned.
Additionally, I refactored vocab::is_annotation_builtin() to use built-in iterator methods.

@filippodebortoli filippodebortoli added bug Something isn't working good first issue Good for newcomers labels Feb 15, 2023
@filippodebortoli filippodebortoli added this to the At some point milestone Feb 15, 2023
@filippodebortoli filippodebortoli marked this pull request as draft February 15, 2023 10:20
@filippodebortoli filippodebortoli linked an issue Feb 22, 2023 that may be closed by this pull request
Refactoring vocab module and fix potentially broken methods. #60
Closed
9 tasks
@phillord
Copy link
Owner

Sorry for long delay.

I think this is a good change. There isn't a need for IRIString (as a new type) now and we might as well ditch it.

I guess you have some more changes to come?

phillord and others added 21 commits March 1, 2024 10:54
@phillord @filippodebortoli
Add oxiri conversion
ec69d56 
Addresses phillord#56
@filippodebortoli
Updates shields in README.
562e197
@filippodebortoli
Updates README for binaries.
a1cc27a
@filippodebortoli
Adds short description of io module and rephrasing on library descrip…
f1be008 
…tion.
@phillord @filippodebortoli
Add branch.org plan file
86ea7bd
@phillord @filippodebortoli
Rename Axiom and AnnotatedAxiom to Component
ec55443
@phillord @filippodebortoli
Add OntologyIDComponent
de8fb79 
Currently not functional, but a place holder for when we remove OntologyID
@phillord @filippodebortoli
Fully support OntologyIDComponent
0230191
@phillord @filippodebortoli
Rename OntologyIDComponent to OntologyID
c9bd1a1
@phillord @filippodebortoli
Move doc IRI support to be an onology component
5e5f62b
@phillord @filippodebortoli
Add documentation
8f94da1
@phillord @filippodebortoli
Support HigherKinded
50cdcb2 
It is now possible to distinguish between an Axiom, SWRL rule or meta
component in constant time.
@phillord @filippodebortoli
Many updates to change axiom to component
6c354f7 
Mostly in documentation and local variables.
@phillord @filippodebortoli
Update summary statistics to include meta components
6b0fe52
@phillord @filippodebortoli
Delete branch.org
2befbfe
@phillord @filippodebortoli
Add branch.org plan file
d258d54
@phillord @filippodebortoli
Rename Axiom and AnnotatedAxiom to Component
4a3282f
@phillord @filippodebortoli
Add OntologyIDComponent
f842cf1 
Currently not functional, but a place holder for when we remove OntologyID
@phillord @filippodebortoli
Fully support OntologyIDComponent
2d3ee17
@phillord @filippodebortoli
Rename OntologyIDComponent to OntologyID
230d1c9
@phillord @filippodebortoli
Move doc IRI support to be an onology component
214a9fd
phillord and others added 15 commits March 1, 2024 11:46
@phillord @filippodebortoli
Add documentation
bedcc2b
@phillord @filippodebortoli
Support HigherKinded
5e608ef 
It is now possible to distinguish between an Axiom, SWRL rule or meta
component in constant time.
@phillord @filippodebortoli
Many updates to change axiom to component
deff861 
Mostly in documentation and local variables.
@phillord @filippodebortoli
Update summary statistics to include meta components
abcf35f
@phillord @filippodebortoli
Delete branch.org
bb0ee44
@KonradHoeffner @filippodebortoli
remove "blah"
da271c4
@filippodebortoli
Fixes redundant import.
04a7143
@filippodebortoli
Forgot to reimport super, fixed.
f8ee7c8
@althonos @filippodebortoli
Manually implement Default to avoid introducing a bound on IRI types (
3bdcf99 
phillord#64)
@althonos @filippodebortoli
Add the AnonymousIndividual variant to AnnotationValue (phillord#66)
ba4c2f6 
* Add `AnonymousIndividual` variant to `AnnotationValue`
* Add test for OWX-roundtripping of anonymous anotation values
* Implement `From<AnonymousIndividual>` for `AnnotationValue`
* Implement parsing of `AnonymousIndividual` annotation values for OWL/XML
* Implement parsing of `AnonymousIndividual` annotation values for RDF/XML
* Minimize `src/ont/owl-rdf/anonymous-annotation-value.owl`
@filippodebortoli
(fix) there was a mistakes cause by using iri_b() instead of as_iri_b…
9defaa5 
…ytes().
@filippodebortoli
(refactor) deprecates IRIString.
f4d9b16
@filippodebortoli
(fix) extends vocab::to_built_in_entity() to return content for OWL::…
af29284 
…Top and OWL::Nothing.
@filippodebortoli
(fix) corrects vocab::is_xsd_datatype to correctly identify initial X…
187aef9 
…SD namespace.
@filippodebortoli
(fix) resolves namespace checking for OWL entity types in vocab::enti…
468cae9 
…ty_for_iri.
@filippodebortoli
Copy link
Collaborator Author

I am closing this, as I have messed up the rebasing. I am opening a new PR with all the changes and properly rebased on top of devel.

@filippodebortoli filippodebortoli mentioned this pull request Mar 1, 2024
Merged
@filippodebortoli filippodebortoli deleted the fixes/broken-tests-vocabulary branch March 1, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
At some point
Development

Successfully merging this pull request may close these issues.

Refactoring vocab module and fix potentially broken methods.
4 participants
@filippodebortoli @phillord @KonradHoeffner @althonos