Use adjacent_sibling instead of sibling (#544)

philss · Feb 20, 2024 · 10a9824 · 10a9824
1 parent b66034f
commit 10a9824
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/floki/finder.ex b/lib/floki/finder.ex
@@ -191,7 +191,7 @@ defmodule Floki.Finder do
     Enum.reverse(html_node.children_nodes_ids)
   end
 
-  defp get_selector_nodes(%Selector.Combinator{match_type: :sibling}, html_node, tree) do
+  defp get_selector_nodes(%Selector.Combinator{match_type: :adjacent_sibling}, html_node, tree) do
     case get_siblings(html_node, tree) do
       [sibling_id | _] -> [sibling_id]
       _ -> []

diff --git a/lib/floki/selector/parser.ex b/lib/floki/selector/parser.ex
@@ -131,7 +131,7 @@ defmodule Floki.Selector.Parser do
   end
 
   defp do_parse([{:plus, _} | t], selector) do
-    {remaining_tokens, combinator} = consume_combinator(t, :sibling)
+    {remaining_tokens, combinator} = consume_combinator(t, :adjacent_sibling)
 
     {%{selector | combinator: combinator}, remaining_tokens}
   end

diff --git a/test/floki_test.exs b/test/floki_test.exs
@@ -1009,9 +1009,9 @@ defmodule FlokiTest do
     assert_find(html, "div > p > span > img + img", expected)
   end
 
-  # Floki.find/2 - Sibling combinator
+  # Floki.find/2 - Adjacent sibling combinator
 
-  test "find sibling element" do
+  test "find adjacent sibling element" do
     html = document!(html_body(~s(
               <a href="t"><img src="/l.png" class="js-l"></a>
               <!-- comment -->