Use recursion instead of Enum.flat_map on find_selectors #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
find_selectors
and it's child functions useEnum.flat_map
to interact through the nodes to find the matching ones.This PR replaces the
Enum.flat_map
andEnum.map
usages with recursion, removing most of the intermediate lists this methods had, and also simplifyingtraverse_with
implementation.This also provides a really small performance improvement. When checking this benchmark with fprof, operations count went from 65867 to 57726, reducing the time to run with fprof from 115ms to 95ms.