Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize UPGRADING.md document #1640

Closed
8 tasks done
mrook opened this issue Sep 10, 2021 · 7 comments
Closed
8 tasks done

Finalize UPGRADING.md document #1640

mrook opened this issue Sep 10, 2021 · 7 comments
Assignees
@kenguest @mrook @siad007
Labels
core
Milestone
3.0.0-RC4

Comments

@mrook
Copy link
Member

mrook commented Sep 10, 2021 •
edited
Loading

UPGRADING.md needs to contain all breaking changes and suggestions/steps to migrate to the new situation.

  • Describe changes to filesize
  • Mention dropping of support for dot notation paths and PackageAsPath task
  • Describe normalization of boolean values
  • Mention removal of ExportProperties
  • FileHash now creates a file by default
  • scpsend no longer an alias
  • describe how boolean values are no longer parsed/special
  • deprecated command attribute removed from ExecTask
@mrook mrook added this to the 3.0.0-RC4 milestone Sep 10, 2021
@siad007
Copy link
Member

siad007 commented Sep 11, 2021 •
edited
Loading

We should also include a paragraph for the project attribute phingVersion and the right usage for it inside a build xml - or maybe this should be covered in the docs?! @mrook @kenguest @jawira WDYT

@siad007 siad007 added the core label Sep 11, 2021
@siad007 siad007 assigned kenguest, mrook and siad007 and unassigned kenguest, mrook and siad007 Sep 11, 2021
@jawira
Copy link
Contributor

jawira commented Sep 12, 2021

@siad007 IMHO phingVersion details should go in documentation.

@jawira
Copy link
Contributor

jawira commented Sep 12, 2021

I have added some text to UPGRADING.md, please check #1644

@jawira
Copy link
Contributor

jawira commented Sep 20, 2021

Hi, I just want to notify that I cant find PackageAsPathTask, maybe it has been removed?

@siad007
Copy link
Member

siad007 commented Sep 20, 2021

AFAIK it was removed 😁

@mrook
Copy link
Member Author

mrook commented Sep 20, 2021

@jawira yep that was removed when I dropped the support for dot notation. I included the latter in the document, but missed the former. Will rectify!

mrook added a commit that referenced this issue Sep 20, 2021
@mrook
Refs #1640 - PackageAsPath task was removed
e46995f
@jawira
Copy link
Contributor

jawira commented Sep 23, 2021

Hi, I see the command attribute from ExecTask was deprecated.
I'm not sure when this was deprecated. But if it was deprecated in v2, it shouldn't be removed in Phing v3?

siad007 added a commit that referenced this issue Oct 2, 2021
@siad007
Update UPGRADING.md
6d8f0a0 
Related to #1640
siad007 added a commit that referenced this issue Oct 2, 2021
@siad007
Update UPGRADING.md
02967c5 
Related to #1640
siad007 added a commit that referenced this issue Oct 2, 2021
@siad007
Update UPGRADING.md
538b416 
Related to #1640
siad007 added a commit that referenced this issue Oct 2, 2021
@siad007
Update UPGRADING.md
f48ba7d 
Related to #1640
@mrook mrook mentioned this issue Nov 12, 2021
Closed
7 tasks
mrook added a commit that referenced this issue Jan 17, 2022
@mrook
Refs #1640 - explain some more about boolean values not being special…
cdc5e5a 
… anymore
@mrook mrook closed this as completed Jan 17, 2022
mrook added a commit that referenced this issue Jan 18, 2022
@mrook
Refs #1662, #1640 - remove deprecated command attribute from ExecTask
bd05391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenguest kenguest

@mrook mrook

@siad007 siad007

Labels
core
Milestone
3.0.0-RC4
Development

No branches or pull requests
4 participants
@kenguest @mrook @jawira @siad007