v3 Upgrade: $excludesFile must be of type Phing\Io\File, string given

[linc]

After upgrading a working build to ^3, I now get this error:

BUILD FAILED
Phing\Type\PatternSet::setExcludesFile(): Argument #1 ($excludesFile) must be of type Phing\Io\File, string given,
 called in /Users/linc/code/porter/vendor/phing/phing/src/Phing/Type/AbstractFileSet.php on line 324

I run Phing from the repo root as ../vendor/bin/phing.

This is the top of my build.xml:

<?xml version="1.0" encoding="UTF-8"?>
<project name="nitro-porter" basedir="." default="main">
    <!-- Name the package folder. -->
    <property name="package" value="nitro-porter" override="true" />

    <!-- Parent directory of this file should be the root. -->
    <resolvepath file=".." propertyName="repo_root" />

    <!-- Define what's in the bundles. -->
    <fileset id="files" dir="${repo_root}" includesfile="file-allowlist.txt" excludesfile="file-denylist.txt" />

Both referenced text files are in the same folder as build.xml.

Deleting excludesfile="file-denylist.txt" from the fileset element allows the build to continue, which suggests this is specifically an exclusion problem, given the includes file works.

Leaving excludesfile="file-denylist.txt" and instead deleting the contents of file-denylist.txt yields the same error as above.

[jawira]

Hi I created a fix for this, I don't have time to write tests right now. Can somebody double check this fixes the issue please?

The PR also has tests.

#1892