Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] PHP compat issues #1563

Merged
merged 11 commits into from
Mar 31, 2021
Merged

[core] PHP compat issues #1563

merged 11 commits into from
Mar 31, 2021

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Mar 31, 2021

  • Skipping some test cases for dependency which will fail on PHP 8.1 and are not part of phing
  • Some changes depends on PHP compat issues

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1563 (85751d5) into main (929c03c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 85751d5 differs from pull request most recent head 2b1ca9e. Consider uploading reports for the commit 2b1ca9e to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1563   +/-   ##
=========================================
  Coverage     55.96%   55.96%           
  Complexity     6913     6913           
=========================================
  Files           355      355           
  Lines         16739    16739           
=========================================
  Hits           9368     9368           
  Misses         7371     7371           
Impacted Files Coverage Δ Complexity Δ
src/Phing/Io/File.php 83.15% <ø> (ø) 91.00 <0.00> (ø)
src/Phing/Io/BufferedReader.php 81.63% <100.00%> (ø) 21.00 <0.00> (ø)
src/Phing/Io/IniFileParser.php 100.00% <100.00%> (ø) 12.00 <0.00> (ø)
.../Phing/Task/System/Pdo/DefaultPDOQuerySplitter.php 97.87% <100.00%> (ø) 20.00 <0.00> (ø)
src/Phing/Task/System/Pdo/PDOSQLExecTask.php 44.57% <100.00%> (ø) 75.00 <0.00> (ø)
src/Phing/Util/StringHelper.php 86.84% <100.00%> (ø) 23.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929c03c...2b1ca9e. Read the comment docs.

@siad007 siad007 changed the title PHP 8.1 compat issues [core] PHP compat issues Mar 31, 2021
@siad007 siad007 merged commit 322a869 into main Mar 31, 2021
@siad007 siad007 deleted the siad007-patch-1 branch March 31, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant