Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XmlLintTask error handler #1599

Merged
merged 22 commits into from
May 14, 2021

Conversation

jawira
Copy link
Contributor

@jawira jawira commented May 4, 2021

Before php 7.2, the callback passed to set_error_handler() received 5 arguments.
Starting php 7.2 the fifth argument is deprecated.
In php 8 the callback only accepts 4 arguments.

closes #1598

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #1599 (2900110) into main (5b8346f) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1599   +/-   ##
=========================================
  Coverage     56.78%   56.78%           
  Complexity     6914     6914           
=========================================
  Files           354      354           
  Lines         16742    16742           
=========================================
  Hits           9507     9507           
  Misses         7235     7235           
Impacted Files Coverage Δ Complexity Δ
src/Phing/Task/System/XmlLintTask.php 64.19% <0.00%> (ø) 31.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8346f...2900110. Read the comment docs.

@mrook mrook merged commit 2376a82 into phingofficial:main May 14, 2021
@jawira jawira deleted the fix-XmlLintTask-error-handler branch May 14, 2021 09:53
@mrook mrook added this to the 3.0.0-RC4 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

XmlLintTask php8 compatibility
2 participants