Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for formatter nested tag to the phpcs task #1614

Merged
merged 7 commits into from
Jul 1, 2021

Conversation

kenguest
Copy link
Member

@kenguest kenguest commented Jun 29, 2021

Add support for formatter nested tag with type and outfile attributes to the phpcs task.
Documentation for same added as PR phingofficial/guide#36 of the guide repo

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #1614 (3df2195) into main (b747fed) will increase coverage by 0.03%.
The diff coverage is 75.86%.

❗ Current head 3df2195 differs from pull request most recent head d53c573. Consider uploading reports for the commit d53c573 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1614      +/-   ##
============================================
+ Coverage     56.84%   56.87%   +0.03%     
- Complexity     6914     6927      +13     
============================================
  Files           354      355       +1     
  Lines         16748    16777      +29     
============================================
+ Hits           9520     9542      +22     
- Misses         7228     7235       +7     
Impacted Files Coverage Δ
.../Phing/Task/Optional/PhpCSTaskFormatterElement.php 58.82% <58.82%> (ø)
src/Phing/Task/Optional/PhpCSTask.php 90.27% <100.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b747fed...d53c573. Read the comment docs.

Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siad007 siad007 merged commit be0e2ae into phingofficial:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants