-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenTask #1617
Add OpenTask #1617
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1617 +/- ##
============================================
+ Coverage 57.67% 57.75% +0.07%
- Complexity 6934 6945 +11
============================================
Files 355 356 +1
Lines 16794 16828 +34
============================================
+ Hits 9686 9719 +33
- Misses 7108 7109 +1
Continue to review full report at Codecov.
|
Thanks @jawira. Can this be automatically tested somehow? And can you write documentation in https://github.com/phingofficial/guide? |
I will add some unit tests, if that's enough for you. I'm going to update the documentation as well. |
@mrook I wrote some tests, surprisingly MacOS and Windows tests pass, but Ubuntu tests don't :( :( :( I think the problem is |
@jawira the problem with ubutu is that it is a plain headless image with no desktop preinstalled.
For our test setup I would suggest to install xdg-open by adding following lines to the github action: - name: Install xdg-utils
run: sudo apt-get install xdg-utils Also interesting project is https://github.com/technodelight/php-cli-cross-platform-open which could be included as a composer dependency. FYI I tagged this issue as an external task (because of external dependencies) therefore it should be included in an own repo. |
@siad007 I think OpenTask is ready.
|
@jawira great stuff - will check ASAP |
LGTM! |
OpenTask
opens a file or URL in the user's preferred application.This should work in Linux, IOS and Windows. But, to be honest I have only tested this task in Ubuntu because I don't own an Apple nor a Windows PC.
Closes #1606