Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdosqlexec] Added failOnConnectionError / Removed obsolete caching attribute #1632

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Aug 23, 2021

  • Added failOnConnectionError
  • Removed not used caching attribute

@siad007 siad007 self-assigned this Aug 23, 2021
@siad007 siad007 added this to the 3.0.0-RC3 milestone Aug 23, 2021
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #1632 (cb9b2f1) into main (14c5bbe) will increase coverage by 0.02%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1632      +/-   ##
============================================
+ Coverage     57.91%   57.93%   +0.02%     
- Complexity     6954     6955       +1     
============================================
  Files           355      355              
  Lines         16829    16831       +2     
============================================
+ Hits           9746     9751       +5     
+ Misses         7083     7080       -3     
Impacted Files Coverage Δ
src/Phing/Task/System/Pdo/PDOTask.php 79.06% <94.11%> (+6.97%) ⬆️
src/Phing/Task/System/Pdo/PDOSQLExecTask.php 78.57% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c5bbe...cb9b2f1. Read the comment docs.

@siad007 siad007 merged commit 4a341e6 into phingofficial:main Aug 23, 2021
@siad007 siad007 deleted the PDOFailOnConnection branch August 23, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant