Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExecTask suggestions #1643

Merged
merged 39 commits into from
Sep 28, 2021
Merged

Add ExecTask suggestions #1643

merged 39 commits into from
Sep 28, 2021

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Sep 11, 2021

Display a suggestion when the executable from ExecTask can be replace by a Task.

jawira and others added 30 commits February 11, 2019 14:27
@jawira jawira mentioned this pull request Sep 11, 2021
@jawira jawira marked this pull request as draft September 11, 2021 18:13
@jawira
Copy link
Contributor Author

jawira commented Sep 11, 2021

I think code is good to go, but I'm waiting your feedback.
I will add some tests in coming days.

@siad007 siad007 added this to the 3.0.0-RC4 milestone Sep 11, 2021
@siad007 siad007 linked an issue Sep 11, 2021 that may be closed by this pull request
@jawira jawira marked this pull request as ready for review September 19, 2021 06:43
@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #1643 (def495e) into main (d482e37) will increase coverage by 0.03%.
The diff coverage is 64.70%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1643      +/-   ##
============================================
+ Coverage     58.19%   58.22%   +0.03%     
- Complexity     6964     7010      +46     
============================================
  Files           356      356              
  Lines         16862    16947      +85     
============================================
+ Hits           9813     9868      +55     
- Misses         7049     7079      +30     
Impacted Files Coverage Δ
src/Phing/Task/System/ExecTask.php 80.00% <64.70%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d482e37...def495e. Read the comment docs.

@siad007 siad007 merged commit 8be6662 into phingofficial:main Sep 28, 2021
@jawira jawira deleted the suggestions branch November 23, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Suggestions for ExecTask
2 participants