Update PHP requirement in Phar manifest #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.json states `^7.3 || ^7.4 || ^8.0` as PHP version requirement, so the Phar is supposed to be compatible with PHP 8.0 as well. Since `^7.3` implies compatibility with PHP 7.4, we don't add it explicitly here.
cmb69
added a commit
to cmb69/polyglot_xh
that referenced
this pull request
Nov 27, 2021
This reverts commit a4aa1cb, because the Phar is still not ready to be installed via Phive[1]. [1] <phingofficial/phing#1650>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composer.json states
^7.3 || ^7.4 || ^8.0as PHP version requirement,so the Phar is supposed to be compatible with PHP 8.0 as well. Since
^7.3implies compatibility with PHP 7.4, we don't add it explicitlyhere.