Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReplaceRegexpTask] Added failOnError support #1866

Merged
merged 7 commits into from
Sep 14, 2024

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Sep 14, 2024

ReplaceRegexpTask does not support a failOnError and just log them as a warning.

  • Added failOnError attribute with default false
  • Changed loglevel from warning to error

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.59%. Comparing base (b2af8ce) to head (9c03df0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Phing/Task/System/ReplaceRegexpTask.php 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1866      +/-   ##
============================================
+ Coverage     53.57%   53.59%   +0.01%     
- Complexity     9809     9812       +3     
============================================
  Files           495      495              
  Lines         24198    24204       +6     
============================================
+ Hits          12963    12971       +8     
+ Misses        11235    11233       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siad007 siad007 merged commit 593141c into main Sep 14, 2024
73 of 74 checks passed
@siad007 siad007 deleted the ReplaceRegexpTaskFailOnError branch September 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant