Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle when divisor b is zero in all division methods in Division.Java #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

handle when divisor b is zero in all division methods in Division.Java #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/com/jwetherell/algorithms/mathematics/Division.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,17 @@
public class Division {

public static final long division(int a, int b) {
if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catches if divisor b is 0

throw new IllegalArgumentException("Divisor cannot be zero.");
}
long result = ((long) a) / ((long) b);
return result;
}

public static final long divisionUsingLoop(int a, int b) {
if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catches if divisor b is 0

throw new IllegalArgumentException("Divisor cannot be zero.");
}
int absA = Math.abs(a);
int absB = Math.abs(b);

Expand All @@ -22,6 +28,9 @@ public static final long divisionUsingLoop(int a, int b) {
}

public static final long divisionUsingRecursion(int a, int b) {
if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catches if divisor b is 0

throw new IllegalArgumentException("Divisor cannot be zero.");
}
int absA = Math.abs(a);
int absB = Math.abs(b);

Expand All @@ -38,6 +47,9 @@ public static final long divisionUsingRecursion(int a, int b) {
}

public static final long divisionUsingMultiplication(int a, int b) {
if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catches if divisor b is 0

throw new IllegalArgumentException("Divisor cannot be zero.");
}
int absA = Math.abs(a);
int absB = Math.abs(b);

Expand All @@ -55,6 +67,9 @@ public static final long divisionUsingMultiplication(int a, int b) {
}

public static final long divisionUsingShift(int a, int b) {
if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catches if divisor b is 0

throw new IllegalArgumentException("Divisor cannot be zero.");
}
int absA = Math.abs(a);
int absB = Math.abs(b);
int tempA, tempB, counter;
Expand All @@ -76,6 +91,9 @@ public static final long divisionUsingShift(int a, int b) {
}

public static final long divisionUsingLogs(int a, int b) {
if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catches if divisor b is 0

throw new IllegalArgumentException("Divisor cannot be zero.");
}
long absA = Math.abs(a);
long absB = Math.abs(b);
double logBase10A = Math.log10(absA);
Expand Down